Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arbitrary instances for Vector/String with Size[P] #471

Merged
merged 7 commits into from
Apr 11, 2018

Conversation

fthomas
Copy link
Owner

@fthomas fthomas commented Apr 10, 2018

This builds up on the work @matthedude did in #455 to provide Arbitrary instances for Vector and String with any Size[P] predicate.

The instance for String will become handy if we add something like FiniteString[N] (#437) to the library.

@codecov
Copy link

codecov bot commented Apr 10, 2018

Codecov Report

Merging #471 into master will decrease coverage by 1.28%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #471      +/-   ##
==========================================
- Coverage   98.06%   96.78%   -1.29%     
==========================================
  Files          60       60              
  Lines         672      684      +12     
  Branches       14       12       -2     
==========================================
+ Hits          659      662       +3     
- Misses         13       22       +9
Impacted Files Coverage Δ
...n/scala/eu/timepit/refined/scalacheck/string.scala 100% <100%> (ø) ⬆️
...ala/eu/timepit/refined/scalacheck/collection.scala 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6239686...70ce608. Read the comment docs.

@fthomas fthomas merged commit 01b87b1 into master Apr 11, 2018
@matthedude
Copy link
Contributor

This is really cool great work 👍

@fthomas fthomas deleted the topic/vectorSizeArbitrary branch April 11, 2018 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants