Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support to generate a Typeable for a refined type #456

Merged
merged 3 commits into from
Mar 26, 2018

Conversation

umbreak
Copy link
Contributor

@umbreak umbreak commented Mar 17, 2018

Added a module for shapeless support of Typeable

@umbreak umbreak force-pushed the shapeless_typeable branch from 1cdf06e to 2d19731 Compare March 17, 2018 02:05
@codecov
Copy link

codecov bot commented Mar 19, 2018

Codecov Report

Merging #456 into master will decrease coverage by 0.56%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #456      +/-   ##
==========================================
- Coverage   98.03%   97.47%   -0.57%     
==========================================
  Files          57       58       +1     
  Lines         662      672      +10     
  Branches       14       12       -2     
==========================================
+ Hits          649      655       +6     
- Misses         13       17       +4
Impacted Files Coverage Δ
.../scala/eu/timepit/refined/shapeless/typeable.scala 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 297d3e5...d825a2e. Read the comment docs.

@umbreak umbreak force-pushed the shapeless_typeable branch from 2841a02 to d825a2e Compare March 19, 2018 09:18
@umbreak umbreak closed this Mar 20, 2018
@umbreak umbreak reopened this Mar 20, 2018
@umbreak
Copy link
Contributor Author

umbreak commented Mar 26, 2018

It would be great if someone can take a look at it, since the I don't see an obvious error for this to fail. Only the build in 2.10.7 is failing without any message.

@fthomas
Copy link
Owner

fthomas commented Mar 26, 2018

I've restarted the build, let's see if that helps.

The changes look good, thanks @umbreak! Adding a new refined-shapeless module is a good idea, although the core module already has a dependency on shapeless. But since this Typeable instance is not essential for refined it makes sense to put it into a new module. Also with the advent of SIP-23, shapeless will become less important for the core module and we can maybe then move the remaining code that uses shapeless into this new module and remove the dependency from the core module.

@fthomas fthomas merged commit 0f9d287 into fthomas:master Mar 26, 2018
@umbreak umbreak deleted the shapeless_typeable branch March 27, 2018 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants