-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add inference rule for Greater[A] ==> Not[Less[A]]
#452
Conversation
Greater[A] ==> Not[Less[A]]
(WIP)Greater[A] ==> Not[Less[A]]
The binary compatability check is failing in 2.10 and 2.11 due to the addition of the new method |
This LGTM, thanks @zainab-ali! What do you think about using If we add this, it would also make sense to add With regards to the MiMa checks: the next version will be 0.9.0 so it is okay to break binary compatability. Just add MiMa exclusions here to ignore those errors. |
Codecov Report
@@ Coverage Diff @@
## master #452 +/- ##
==========================================
+ Coverage 98.03% 98.03% +<.01%
==========================================
Files 57 57
Lines 660 662 +2
Branches 12 12
==========================================
+ Hits 647 649 +2
Misses 13 13
Continue to review full report at Codecov.
|
Right, Integrating mima and scalafmt into the build like this is a great idea :) I'll start doing that for my own projects! EDIT: There are still some mima exclusions I need to add Ok, exclusions added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks again @zainab-ali!
If a value is greater than
x
, then it also must not be less thanx
.What do you think of introducing it as an inference rule?