Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize type class instances #438

Merged
merged 7 commits into from
Feb 9, 2018
Merged

Reorganize type class instances #438

merged 7 commits into from
Feb 9, 2018

Conversation

fthomas
Copy link
Owner

@fthomas fthomas commented Feb 8, 2018

This is the same as #392 but on top of current master.

@fthomas fthomas force-pushed the topic/reorg-instances2 branch from e700795 to 586e8bc Compare February 8, 2018 13:28
@codecov
Copy link

codecov bot commented Feb 8, 2018

Codecov Report

Merging #438 into master will decrease coverage by 1.33%.
The diff coverage is 95.34%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #438      +/-   ##
==========================================
- Coverage   97.99%   96.66%   -1.34%     
==========================================
  Files          57       57              
  Lines         649      660      +11     
  Branches       14       12       -2     
==========================================
+ Hits          636      638       +2     
- Misses         13       22       +9
Impacted Files Coverage Δ
...ed/src/main/scala/eu/timepit/refined/boolean.scala 100% <100%> (ø) ⬆️
...red/src/main/scala/eu/timepit/refined/string.scala 100% <100%> (ø) ⬆️
...hared/src/main/scala/eu/timepit/refined/char.scala 100% <100%> (ø) ⬆️
...ed/src/main/scala/eu/timepit/refined/numeric.scala 100% <100%> (ø) ⬆️
...src/main/scala/eu/timepit/refined/collection.scala 100% <100%> (ø) ⬆️
...ed/src/main/scala/eu/timepit/refined/generic.scala 42.85% <27.27%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55d569c...035c146. Read the comment docs.

@fthomas
Copy link
Owner Author

fthomas commented Feb 9, 2018

With 3c546f6 many of the numeric inference tests failed with Scala 2.10. Let's see if they become green again after moving the boolean inference instances.

@fthomas fthomas force-pushed the topic/reorg-instances2 branch from bda4bfa to 231a0b2 Compare February 9, 2018 21:50
@fthomas
Copy link
Owner Author

fthomas commented Feb 9, 2018

I've decided to limit this PR only to Validate instances because I had trouble moving the Inference instances without breaking tests. It is also not clear where put some of the instances that involve more than one predicate. For example, should implicit def existsNonEmptyInference[P]: Exists[P] ==> NonEmpty be in the Forall, Empty, or Not companion?

@fthomas fthomas merged commit 356bbb5 into master Feb 9, 2018
@fthomas fthomas deleted the topic/reorg-instances2 branch February 9, 2018 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant