Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Arbitrary instance for NonEmpty Strings #415

Merged
merged 5 commits into from
Jan 30, 2018

Conversation

fthomas
Copy link
Owner

@fthomas fthomas commented Jan 16, 2018

No description provided.

@fthomas
Copy link
Owner Author

fthomas commented Jan 22, 2018

This is not binary compatible with 0.8 and therefore needs to wait until 0.9.

@codecov
Copy link

codecov bot commented Jan 30, 2018

Codecov Report

Merging #415 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #415      +/-   ##
==========================================
+ Coverage   95.76%   95.79%   +0.02%     
==========================================
  Files          46       46              
  Lines         590      594       +4     
  Branches       12       14       +2     
==========================================
+ Hits          565      569       +4     
  Misses         25       25
Impacted Files Coverage Δ
...n/scala/eu/timepit/refined/scalacheck/string.scala 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2319748...22f4272. Read the comment docs.

@fthomas fthomas merged commit f5949db into master Jan 30, 2018
@fthomas fthomas deleted the topic/nonEmptyStringArbitrary branch January 31, 2018 22:27
@fommil
Copy link
Contributor

fommil commented Feb 28, 2018

you might want to do a .toString on the char to avoid an implicit. Wartremover and scalafix usually catch that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants