Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix https://github.com/mkeeter/fstl/issues/57 #58

Closed
wants to merge 1 commit into from

Conversation

fake-name
Copy link

@fake-name fake-name commented Jul 30, 2020

Disable annoying warning.

See #57

If this is legitimately a issue with some software out there, a non-modal way of alerting would be OK, just don't pop up a dialog EVERY time I open a file.

mkeeter added a commit that referenced this pull request Jul 31, 2020
@mkeeter
Copy link
Collaborator

mkeeter commented Jul 31, 2020

This is an issue with other software out there: here's a thread calling out Solidworks specifically and listing several tools that break if solid is the first word in the binary header (also this and this).

Still, I think it's fair to declare this "not fstl's problem" and remove the warning. I've fixed it in 78d0c92, removing the whole code-path rather than just commenting out this check.

@fake-name
Copy link
Author

Awesome!

This is an issue with other software out there

Yeah, but that software is the stuff that's broken. From the original STL specification, this is a invalid heuristic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants