Fix performance issues with MemoryFileSystem.rm #1725
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1724.
The idea is that the nominal case is deleting an existing file, and verifying that a path corresponds to a file is an extremely fast key-existence check on the underlying store (dict). Thus by checking first if it's a file we escape the expensive exists check, which must scan all keys to check if the path is a prefix directory for some file.
Now the time to write a single file is roughly constant (instead of linear in the number of files), while the time to remove all files scales linearly with the number of files (instead of quadratically).
Before:
After:
Before:
After: