-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
spec: support exists() on directories pre-cache #237
Conversation
The test earliest passes but the other failures are caused by /issues/240. CC: @hayesgb @TomAugspurger (it would be really cool to have this, since a lot of codepaths that we have depend on this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. One small question.
I can't see the question. |
Strange, my review was lost. The gist was: should the |
There are multiple places where a regular |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI is passing now. Planning to merge in a few hours.
Thanks @isidentical! |
While the first one is returning False, after the cache the second one is returning true. The reason is that, the
exists()
implementation first tries to check whether a such a directory exists by traversing the cache and when it fails it tries to check if a blob namedpath
exists though if the directory is not cached, it doesn't check for that. This patch makes it fallback to the default implementation which is basically checking the result ofinfo()
.