Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding regression test for record type with attributes #958

Merged
merged 1 commit into from
Jul 10, 2020
Merged

Adding regression test for record type with attributes #958

merged 1 commit into from
Jul 10, 2020

Conversation

nojaf
Copy link
Contributor

@nojaf nojaf commented Jul 10, 2020

Is no longer a bug #941.
Fixes #941

Smaug123
Smaug123 approved these changes Jul 10, 2020
View reviewed changes
Copy link
Contributor

@Smaug123 Smaug123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - do we know which commit fixed this?

@nojaf
Copy link
Contributor Author

nojaf commented Jul 10, 2020

That would be the changes in #951

@nojaf nojaf merged commit 17bfa28 into fsprojects:master Jul 10, 2020
@nojaf nojaf deleted the fix-941 branch July 10, 2020 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Smaug123 Smaug123 Smaug123 approved these changes

@jindraivanek jindraivanek Awaiting requested review from jindraivanek

@JackMatusiewiczGR JackMatusiewiczGR Awaiting requested review from JackMatusiewiczGR

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Extra spaces inserted in record definition
2 participants
@nojaf @Smaug123