-
-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for editorconfig #940
Conversation
What an exciting world is this OSS development, with developers racing to complete features ;-) @nojaf, you are on a good track to finish this, so I will no purse it anymore. Just two things came to my mind when reviewing your code:
|
Hey @josefblaha, again apologies for not creating my PR sooner. I should have made a draft PR last Friday, that may have avoided this. As for your feedback:
|
No problem. Any code written has a value for me, as I'm still learning the language. Ad tabs. You're right, but there is a corner case: |
This is ready for now.
|
Current attempt for solving #650.
EditorConfig.Core was forked to https://github.com/nojaf/editorconfig-core-net.
There I created a slightly modified version, mainly having a netstandard2.0 only configuration.
I used ILRepack to merge in the editorconfig core to Fantomas.dll.
I published
Fantomas.EditorConfig.Core
as unlisted to Nuget.I fear that this PR is already competing with #939, for that @josefblaha I'm sorry.
Last Friday I already had those changes to
readConfiguration
.Main things left to do here are: