-
-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create initial benchmark. #878
Conversation
Interesting, I got
|
@jindraivanek, hmm yeah that might have been a lie there 🙈 I'm thinking about pushing the results of the benchmark to Azure, in Application Insights. |
I found a github action that does easy performance comparisons over time for perf tests: https://github.com/rhysd/github-action-benchmark It doesn't currently have support for benchmark.net, but it looks very easy to add support. We'd just have to PR a benchmark.net-specific parsing function for the generated files right here. I mostly am pointing this out because I see that your current CI setup is github-actions-centric. |
Regarding the overall speed of running the tests, I'd say the most impactful things to do would be to lower the amount of warming up/pre-work measurement that's done. Benchmark.net actually does a ton of additional work before running your tests to determine what sorts of jitter/constant factors to account for in your tests. Then, once the warmup is done it does your tests a large number of times. Therefore you can speed up the iterations by
|
I think you can tweak the attributes so that not as many tests are done so the CI would run faster. the memory one does do a lot of iterations. |
CI now runs between nine and elven minutes. Results are stored in Azure Table Storage. |
Following up on #867, a first attempt to create a benchmark for the largest file in Fantomas.
So this works on my machine ™, how do we want to run this on CI?
It took around 30 min to run so I'm not sure we want to have this for each PR build.