Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly handle use binding follow by let bang #877

Merged
merged 4 commits into from
May 30, 2020
Merged

Correctly handle use binding follow by let bang #877

merged 4 commits into from
May 30, 2020

Conversation

nojaf
Copy link
Contributor

@nojaf nojaf commented May 29, 2020

Fixes #876

@nojaf nojaf requested a review from jindraivanek May 29, 2020 08:53
@nojaf nojaf requested a review from JackMatusiewiczGR May 29, 2020 13:32
JackMatusiewiczGR
JackMatusiewiczGR suggested changes May 30, 2020
View reviewed changes
Copy link

@JackMatusiewiczGR JackMatusiewiczGR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there's a bug with the let/use rec case. Let me know if I'm wrong and I'll approve

@nojaf nojaf requested a review from JackMatusiewiczGR May 30, 2020 13:58
@nojaf nojaf merged commit 5cda99e into fsprojects:master May 30, 2020
@nojaf nojaf deleted the fix-876 branch December 11, 2020 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JackMatusiewiczGR JackMatusiewiczGR JackMatusiewiczGR approved these changes

@jindraivanek jindraivanek Awaiting requested review from jindraivanek

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Stackoverflow problem with let bang in match
2 participants
@nojaf @JackMatusiewiczGR