Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Line comment after { leads to multiline construct. #765

Merged
merged 2 commits into from
Apr 19, 2020
Merged

Line comment after { leads to multiline construct. #765

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7d04576
Line comment after { leads to multiline construct.
nojaf Apr 18, 2020
9d73ec5
Merge branch 'master' into fix-516
nojaf Apr 19, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions src/Fantomas.Tests/RecordTests.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -869,4 +869,17 @@ let useAddEntry () =
created: string |}) ->
// foo
bar ()
"""

[<Test>]
let ``line comment after { should make record multiline`` () =
formatSourceString false """let meh = { // this comment right
Name = "FOO"; Level = 78 }
""" config
|> prepend newline
|> should equal """
let meh =
{ // this comment right
Name = "FOO"
Level = 78 }
"""
1 change: 1 addition & 0 deletions src/Fantomas/CodePrinter.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -821,6 +821,7 @@ and genExpr astContext synExpr =
| Record(inheritOpt, xs, eo) ->
let shortRecordExpr =
sepOpenS +>
leaveLeftBrace synExpr.Range +>
optSingle
(fun (inheritType, inheritExpr) -> !- "inherit " +> genType astContext false inheritType +> genExpr astContext inheritExpr +> onlyIf (List.isNotEmpty xs) sepSemi)
inheritOpt +>
Expand Down