Restore --stdin flag functionality #656
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the
--stdin
functionality which seemed to not work when the new version started usingArgu
for parsing the CLI arguments.I have also preserved the original functionality where stdin input can only be read if redirected through a pipe:
Examples
Current master build:
Fantomas.CoreGlobalTool 3.1.0:
This PR:
Notes
The stdIn reader functionality is currently line capped (to 2000 lines, see
StdLineLimit
), to avoid memory overflows. The defaultConsole.ReadLine()
character limit is 256 characters, so that takes care of memory overflows.We could potentially relax that limit, depending on how people use the
--stdin
functionality i.e. I am assuming this can be used as an editor hook, to format code selections.