Feature/config file #606
Merged
Feature/config file #606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah, I think single function for reading config is all we need in FSAC, looks good to me |
jindraivanek
approved these changes
Dec 24, 2019
|
Great work! |
Closed
|
Please update documentation for this configuration, so probably Ionide, etc can implement their IDE settings. thanks. |
|
This configuration was deprecated in v4 in favour of |
|
@nojaf Thanks for your response. Wow, this is really great. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial attempt to resolve #354.
The configuration file is a JSON file according to the schema.
I've extended the public API with
GetVersion()ReadConfiguration()so tooling could benefit from this as well.
Any feedback on the public API is welcome. @Krzysztof-Cieslak I think this is sufficient for FSAutocomplete, let me know what you think.
TODO:
Once merged: