Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/bracket on separate line #538

Closed
wants to merge 0 commits into from
Closed

Feature/bracket on separate line #538

wants to merge 0 commits into from

Conversation

nojaf
Copy link
Contributor

@nojaf nojaf commented Oct 25, 2019

This is the first attempt for #453.

jindraivanek
jindraivanek reviewed Oct 28, 2019
View reviewed changes
src/Fantomas/FormatConfig.fs Outdated
@@ -39,6 +40,7 @@ type FormatConfig =
ReorderOpenDeclaration = false
SpaceAroundDelimiter = true
KeepNewlineAfter = false
BracketOnSeparateLine = false // TODO: add to cli
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That has been done, the comment needs to removed.

@fahrenq
Copy link

fahrenq commented Dec 31, 2019 •
edited
Loading

Hey guys,

Any estimate on this?

Could you maybe use some help from me? I'm ready to take over if needed, just please provide a little bit of context :)

@nojaf
Copy link
Contributor Author

nojaf commented Dec 31, 2019

Hello @fahrenq, I'm picking this up early 2020 in collaboration with the team at G-Research.
I cannot give any estimate I'm afraid but it will have the highest priority in the upcoming sponsorship contract.

@nojaf
Copy link
Contributor Author

nojaf commented Jan 20, 2020

Hello @fahrenq, the internal conversations about this are still ongoing. It will take some time before I can start working on this again. Just so you know.

@fahrenq
Copy link

fahrenq commented Jan 20, 2020 •
edited
Loading

Hey Florian,

Thank you very much for the update. I appreciate it!

@nojaf nojaf closed this Feb 4, 2020
@nojaf nojaf force-pushed the feature/bracket-on-separate-line branch from bd31520 to c21db71 Compare February 4, 2020 12:42
@nojaf
Copy link
Contributor Author

nojaf commented Feb 4, 2020

Hey @fahrenq , I messed this branch and by accident closed this PR.
The intention to work on this is still there, will open a new PR when I have something.

@fahrenq
Copy link

fahrenq commented Feb 4, 2020

Awesome! Thank you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jindraivanek jindraivanek jindraivanek left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nojaf @fahrenq @jindraivanek