Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add active pattern for empty computation expression #3141

Merged
merged 3 commits into from
Dec 12, 2024

Conversation

nojaf
Copy link
Contributor

@nojaf nojaf commented Dec 10, 2024

Fixes #3140

I took a bit of a shortcut, that is why there is an additional space after formatting.
This might be ok to for now.

@nojaf
Copy link
Contributor Author

nojaf commented Dec 10, 2024

The generated lex.fsi no longer seems valid.
module Ranges =/// Rule token is invalid according to the latest SDK.
I'm not sure why this generating to no longer working.

@Martin521 does this ring a bell? Did anything change in that area?

@Martin521
Copy link

No, I am not aware of changes.
What exactly do you mean by your comment? Does compilation of the generated lex.fs create errors? And the error message is module Ranges =/// Rule token?
module Ranges and //Rule token are in quite different places in lex.fs.

@nojaf
Copy link
Contributor Author

nojaf commented Dec 10, 2024

Yes, the generated lex.fs contains invalid code and compilation fails.
I can't quite piece together why this is happening now.
Maybe you have seen this before, since you did some work in that area.

@nojaf nojaf merged commit 5d7a379 into fsprojects:v7.0 Dec 12, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants