Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix output filename #3025

Merged
merged 6 commits into from
Dec 22, 2023
Merged

Fix output filename #3025

merged 6 commits into from
Dec 22, 2023

Conversation

dawedawe
Copy link
Member

Uh, there really seems to be no one using this :(
I'll add tests later.

image

@@ -42,3 +42,34 @@ let ``incorrectly formatted file should be written`` () =
exitCode |> should equal 0

output |> should contain "has been written"

[<Test>]
let ``file should be written to out folder when input folder has trailing slash`` () =
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one fails in main because A.fs becomes .fs in the output folder

@dawedawe dawedawe marked this pull request as ready for review December 21, 2023 22:43
Copy link
Contributor

@nojaf nojaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dawedawe dawedawe merged commit fc341e8 into fsprojects:main Dec 22, 2023
5 checks passed
@dawedawe dawedawe deleted the fix_output_filename branch December 22, 2023 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants