Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 2953 - Comment lost after named pat pair. #3020

Merged
merged 4 commits into from
Dec 20, 2023
Merged

Fix 2953 - Comment lost after named pat pair. #3020

merged 4 commits into from
Dec 20, 2023

Conversation

dawedawe
Copy link
Member

fixes #2953

Currently, just a draft as the fix is not idempotent.

@nojaf
Copy link
Contributor

nojaf commented Dec 20, 2023

Thanks, at some point I remember looking into this one as well.
Maybe take a peek at main...nojaf:fantomas:fix-2953.
Could still be relevant.

@dawedawe
Copy link
Member Author

Thanks, at some point I remember looking into this one as well. Maybe take a peek at main...nojaf:fantomas:fix-2953. Could still be relevant.

Cool, thanks. That did the trick :)

@dawedawe dawedawe marked this pull request as ready for review December 20, 2023 13:14
nojaf
nojaf approved these changes Dec 20, 2023
View reviewed changes
Copy link
Contributor

@nojaf nojaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dawedawe dawedawe merged commit 5dcd417 into fsprojects:main Dec 20, 2023
5 checks passed
@dawedawe dawedawe deleted the fix-2953 branch December 20, 2023 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nojaf nojaf nojaf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Comment lost after named pat pair
2 participants
@dawedawe @nojaf