Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use workaround from 628 for nested modules, too #2870

Merged
merged 2 commits into from
May 5, 2023
Merged

Use workaround from 628 for nested modules, too #2870

merged 2 commits into from
May 5, 2023

Conversation

dawedawe
Copy link
Member

@dawedawe dawedawe commented May 3, 2023

fixes #2867

nojaf
nojaf approved these changes May 4, 2023
View reviewed changes
Copy link
Contributor

@nojaf nojaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rocksolid PR, thanks @dawedawe!

@nojaf nojaf merged commit 1227fca into fsprojects:main May 5, 2023
@dawedawe dawedawe deleted the fix_2867 branch May 5, 2023 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nojaf nojaf nojaf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect indentation of compiler-conditional accessibility modifier for module definition
2 participants
@dawedawe @nojaf