Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Indent cramped record field body if indent_size is low. #2802

Merged
merged 6 commits into from
Mar 27, 2023
Merged

Indent cramped record field body if indent_size is low. #2802

merged 6 commits into from
Mar 27, 2023

Conversation

nojaf
Copy link
Contributor

@nojaf nojaf commented Mar 27, 2023

There most likely is an upstream parser bug involved here.
This fixes #2801 by adding an extra indent when necessary.

@nojaf
Copy link
Contributor Author

nojaf commented Mar 27, 2023

Also found a fix for #2803.
@dawedawe please review. I'm applying the same trick now as we saw.

@nojaf nojaf requested a review from dawedawe March 27, 2023 17:08
@nojaf nojaf linked an issue Mar 27, 2023 that may be closed by this pull request
Idempotency problem when comment after opening brace in inherit record #2803
Closed
3 tasks
@nojaf nojaf merged commit e6465ca into fsprojects:main Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dawedawe dawedawe dawedawe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@nojaf @dawedawe