Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Stroustrup record member declaration indent issue #2788

Merged
merged 2 commits into from
Mar 7, 2023

Conversation

josh-degraw
Copy link
Contributor

Closes #2787

@josh-degraw josh-degraw changed the base branch from main to v6.0 March 6, 2023 21:07
Copy link
Contributor

@nojaf nojaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks!

@nojaf nojaf merged commit 963f242 into fsprojects:v6.0 Mar 7, 2023
@josh-degraw josh-degraw deleted the stroustrup-member-fix branch March 7, 2023 17:31
@josh-degraw
Copy link
Contributor Author

@nojaf Would you mind if we made a new alpha release with the latest changes? It looks like this change seems to solve all the issues I found locally and I might be able to actually get my team's code updated to use Stroustrup again finally with this change haha

@nojaf
Copy link
Contributor

nojaf commented Mar 7, 2023

Yup, just add the release notes to the v6 branch and publish from there.
No need for a github release. We will do that eventually.

nojaf pushed a commit that referenced this pull request Mar 17, 2023
* Fix issue with Stroustrup member indents

* Move unindent closer to indent
nojaf pushed a commit that referenced this pull request Mar 27, 2023
* Fix issue with Stroustrup member indents

* Move unindent closer to indent
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Record member declarations can break with Stroustrup enabled
2 participants