Cursor with defines #2774
Merged
Cursor with defines #2774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dawedawe
requested changes
Feb 19, 2023
nojaf
force-pushed
the
cursor-with-defines
branch
from
bee8160 to
d69b7bf
Compare
nojaf
force-pushed
the
cursor-with-defines
branch
from
437e223 to
a8986d4
Compare
dawedawe
reviewed
Mar 16, 2023
| @@ -4,7 +4,8 @@ module internal Fantomas.Core.CodeFormatterImpl | |||
| open FSharp.Compiler.Diagnostics | |||
| open FSharp.Compiler.Syntax | |||
| open FSharp.Compiler.Text | |||
| open Fantomas.Core.SyntaxOak | |||
| open SyntaxOak | |||
There was a problem hiding this comment.
open Statement not needed
Suggested change
| open SyntaxOak |
dawedawe
reviewed
Mar 16, 2023
Comment on lines
38
to
39
| override this.Equals _ = false | ||
| override this.GetHashCode() = Int32.MinValue |
There was a problem hiding this comment.
Suggested change
| override this.Equals _ = false | |
| override this.GetHashCode() = Int32.MinValue | |
| override _.Equals _ = false | |
| override _.GetHashCode() = Int32.MinValue |
dawedawe
approved these changes
Mar 16, 2023
Co-authored-by: dawe <[email protected]>
nojaf
force-pushed
the
cursor-with-defines
branch
from
a8986d4 to
f58c7e5
Compare
nojaf
commented
Mar 18, 2023
nojaf
added a commit
that referenced
this pull request
Mar 27, 2023
* Refactor processing of multiple defines into separate module. * Improve correctness of the behavior. * Fix remaining Util tests. * Format MultipleDefineCombinations.fs * Apply suggestions from code review Co-authored-by: dawe <[email protected]> * Remove redundant elif * Implement Equals and GetHashCode. --------- Co-authored-by: dawe <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related to #2727 and tries to tackle the scenario where we format the code multiple times and merge each back into a single result.
For example:
Fantomas will format this three times:
[][ "A" ][ "B" ]In this PR, I'm trying to merge all the results in one go. In the
mainbranch we are reducing the results instead, so I think for large files this will be quite beneficial in terms of performance.@dawedawe and @josh-degraw could you please carefully review this PR? The goal was to make everything a bit more understandable than how it works today. I'm not quite sure I've hit the mark just yet.
There are some TODOs left, please let me know what you would do in those cases. I'm not quite sure about everything just yet.