Add separate CodeFormatter.FormatDocumentAsync overloads with cursor and config #2763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nojaf
requested changes
Feb 3, 2023
src/Fantomas.Core/CodeFormatter.fsi
Outdated
| /// <param name="cursor">The location of a cursor, zero-based.</param> | ||
| static member FormatDocumentAsync: | ||
| isSignature: bool * source: string * ?config: FormatConfig * ?cursor: pos -> Async<FormatResult> | ||
| isSignature: bool * source: string * cursor: pos -> Async<FormatResult> |
There was a problem hiding this comment.
This overload seems excessive and I don't see it being used in practice.
If you want to use this then you should use the next one and pass the default config.
Please remove it.
CHANGELOG.md
Outdated
| @@ -1,5 +1,10 @@ | |||
| # Changelog | |||
|
|
|||
| ## [Unreleased] | |||
There was a problem hiding this comment.
There was no way you could have known this but for the non-main branch, I prefer that you don't add a changelog entry. This makes rebasing the v6 branch with the main branch easier. (fewer conflicts).
| config, | ||
| ?cursor = cursor | ||
| ) | ||
| match cursor with |
There was a problem hiding this comment.
Could you swap the order, please?
In this case, I prefer to have the shortest case first.
DedSec256
force-pushed
the
dedsec256-overload-with-cursor
branch
from
6d8e95d to
b990f9c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2749 (comment)