Add initial regression script #2719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nojaf
commented
Jan 16, 2023
|
|
||
| // Run repositories | ||
| for repo in repositories do | ||
| (run repo).Wait() |
There was a problem hiding this comment.
This Wait bit might be sacrilege, please let me know what the idiomatic thing to do here in F# is.
There was a problem hiding this comment.
How about
let t = run repo
t |> Async.AwaitTask |> Async.RunSynchronouslyThere was a problem hiding this comment.
I thought of that but it feels a bit strange to move to the Async world at the end for this.
As the tasks are hot, I think staying in the Task world makes more sense.
|
I like it a lot and yes, running this manually before a release or whenever one feels like it should be enough as it's a rather big work load. |
|
I'm going to merge this to be able to try out the GitHub Action, we can refine the script later on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first attempt to introduce some more regression testing.
The idea is to clone a repository (that already uses Fantomas), build it, and format it using the latest code. Afterwards, build the repository again to verify that still works.
This isn't a silver bullet and does not detect absolutely everything, but I think it is a start.
We could run this manually before we are going to release a new version. I don't think we want this before every PR.
All feedback is welcome.
Todo: