Keep Subsequent identifier links on the same line. #2713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nojaf
commented
Jan 13, 2023
| """ | ||
|
|
||
| [<Test>] | ||
| let ``very long chain with a some index expressions`` () = |
There was a problem hiding this comment.
@dawedawe this one is a bit tricky. The whole chain does not fit within the MaxDotGetExpressionWidth boundary, but there is no application to chop it logically.
nojaf
commented
Jan 13, 2023
| @@ -1123,7 +1129,7 @@ let genExpr (e: Expr) = | |||
| short | |||
| (match leadingChain with | |||
| | [] -> sepNone | |||
| | head :: links -> genFirstLinkAndIndentOther head links) | |||
| | head :: links -> genLink false head +> indent +> genIndentedLinks true links +> unindent) | |||
There was a problem hiding this comment.
@dawedawe I changed the implementation to only consider the max_line_length when there are only simple links in the chain.
You basically print the first one, if the second fits after it, great, if not put it on the next line. I think this is reasonable.
dawedawe
approved these changes
Jan 13, 2023
| @@ -1123,7 +1129,7 @@ let genExpr (e: Expr) = | |||
| short | |||
| (match leadingChain with | |||
| | [] -> sepNone | |||
| | head :: links -> genFirstLinkAndIndentOther head links) | |||
| | head :: links -> genLink false head +> indent +> genIndentedLinks true links +> unindent) | |||
Co-authored-by: dawe <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2712.