Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

genNode for SimplePatNode. #2697

Merged
merged 2 commits into from
Jan 10, 2023
Merged

genNode for SimplePatNode. #2697

merged 2 commits into from
Jan 10, 2023

Conversation

nojaf
Copy link
Contributor

@nojaf nojaf commented Jan 9, 2023 •
edited
Loading

Fixes #2692

@nojaf nojaf requested a review from dawedawe January 9, 2023 15:21
@dawedawe
Copy link
Member

dawedawe commented Jan 9, 2023

Fixes #2686

I think this should be 2692, otherwise all good.

@nojaf
Copy link
Contributor Author

nojaf commented Jan 10, 2023

I think this should be 2692, otherwise all good.

Yup, thanks!

@nojaf nojaf merged commit 1af0dfe into fsprojects:main Jan 10, 2023
@nojaf nojaf deleted the fix-2692 branch January 30, 2023 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dawedawe dawedawe dawedawe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Comment not assigned to first parameter in constructor
2 participants
@nojaf @dawedawe