Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Server gc #2655

Merged
merged 2 commits into from
Dec 16, 2022
Merged

Enable Server gc #2655

merged 2 commits into from
Dec 16, 2022

Conversation

nojaf
Copy link
Contributor

@nojaf nojaf commented Dec 16, 2022

On my local machine:

Before:

Benchmark/step-0> | Method |     Mean |   Error |  StdDev | Rank |       Gen0 |      Gen1 |     Gen2 | Allocated |
Benchmark/step-0> |------- |---------:|--------:|--------:|-----:|-----------:|----------:|---------:|----------:|
Benchmark/step-0> | Format | 136.0 ms | 0.55 ms | 0.46 ms |    1 | 13250.0000 | 2500.0000 | 750.0000 | 157.83 MB |

After:

Benchmark/step-0> | Method |     Mean |    Error |   StdDev | Rank |     Gen0 |     Gen1 | Allocated |
Benchmark/step-0> |------- |---------:|---------:|---------:|-----:|---------:|---------:|----------:|
Benchmark/step-0> | Format | 98.23 ms | 0.772 ms | 0.722 ms |    1 | 600.0000 | 400.0000 | 157.82 MB |

I think we should do this for the daemon as well, as this makes sense for the request/response model of an LSP.
FsAutoComplete does this as well.

@nojaf nojaf merged commit 90c8e48 into fsprojects:v5.2 Dec 16, 2022
@nojaf nojaf mentioned this pull request Jan 2, 2023
@nojaf nojaf deleted the server-gc branch January 30, 2023 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant