Capture StartEndRange information in SynExpr.AnonRecd to fix #2566

[dawedawe]

fixes the lost comments in #2566

[nojaf]

A good start here! Please dot some more i's and cross some t's and we can merge this in.

[dawedawe]

Adding genTriviaFor for the opening braces shows a separator problem:
In copy expressions:

let a =
    {| foo with// test1

In record instances:

let x =
    {| Y =// test1

The later could be solved be using
genTriviaFor SynExpr_AnonRecd_OpeningBrace openingBrace sepOpenAnonRecdFixed
instead of
genTriviaFor SynExpr_AnonRecd_OpeningBrace openingBrace sepOpenAnonRecd
but I'm really not sure if this is the way to go here.

[nojaf]

Looks good! Many thanks

[nojaf]

You could force the comment to be printed after {|, similar to how it is done for normal records.

We can merge this PR as is, for my part. It's up to you.

[dawedawe]

You could force the comment to be printed after {|, similar to how it is done for normal records.

Ah thanks, that was way easier than I thought.

[nojaf]

I know it is the same as we have it for regular records.
But in the future, we might want to have something like

{| // foo
   bar with
    A = 1
    B = 2 |}

I don't feel strongly about this, so no need to address this in this PR.

[dawedawe]

I think this should better be handled in a separate PR.

[nojaf]

Sounds good to me!
I have no idea why the CI is failing, the NuGet lock file should not be throwing errors.
I think we need to apply the steps explained here.
I'll do that in a separate PR so you can rebase with main.

[nojaf]

There is also dotnet/fsharp#13678.
I hope it is ok.