Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to disable indentation of DU cases #2570

Closed
wants to merge 2 commits into from

Conversation

anchann
Copy link

@anchann anchann commented Oct 10, 2022

First PR here, sorry for any blunders.

We are in the process of adopting Fantomas into our code base, and need some additional configuration options to make the auto-formatted code compatible with our code guide. From the docs I couldn't quite figure out how strong your stance is on "only official formatting!", but it seems that you allowed some customizations (like stroustrup style, which is awesome!), so hopefully what I'm trying to do is okay.

Question: even though the code update works on the CLI, I could not get the unit test I wrote to pass, and can't figure out why. Please help.

@nojaf
Copy link
Contributor

nojaf commented Oct 10, 2022

Hello,

We are extremely strict on what settings are added to Fantomas, so I will not consider any PR without prior approval via the feature template. And again, we are not looking for stylistic settings.

Stroustrup is an exception to this, as we have an implementation prior to the style guide approval. That being said, the people that are interested in Stroustrup have engaged in dialogue with the style guide (see fsharp/fslang-design#706).
It took Stroupstrup years to get into Fantomas, so we did not tread this lightly.

What you propose here is against the guidance of both style guides, and thus we are not interested in this setting.
It is not worth it, and you are your team will need to get accustomed to what Fantomas produces as output.

@nojaf nojaf closed this Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants