-
-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: use same constraint >= 6.0.1 for Fantomas.Core and Fantomas.FCS #2375
Fix: use same constraint >= 6.0.1 for Fantomas.Core and Fantomas.FCS #2375
Conversation
@nojaf that was a small fix 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this PR. Though the F# Core problem is fixed, there are a lot of changes to the lock file.
One that leads to a difference in Fantomas.Client
, which I want to avoid.
paket.lock
Outdated
Microsoft.VisualStudio.Threading (>= 16.9.60) - restriction: >= netstandard2.0 | ||
Nerdbank.Streams (>= 2.6.81) - restriction: >= netstandard2.0 | ||
Newtonsoft.Json (>= 12.0.2) - restriction: >= netstandard2.0 | ||
StreamJsonRpc (2.11.35) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We cannot have this change.
The dependencies of Fantomas.Client changed because of this. This might break in Visual Studio.
fbe262f
to
7d6c0fe
Compare
This time it should be better |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup, wonderful!
Thank you.
All builds green! |
@thinkbeforecoding I've pushed beta 2 to NuGet, it will be available once the indexing is done. |
This is a fix for #2374