Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: use same constraint >= 6.0.1 for Fantomas.Core and Fantomas.FCS #2375

Merged
merged 2 commits into from
Jul 19, 2022

Conversation

thinkbeforecoding
Copy link
Contributor

This is a fix for #2374

@thinkbeforecoding
Copy link
Contributor Author

@nojaf that was a small fix 😄

Copy link
Contributor

@nojaf nojaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR. Though the F# Core problem is fixed, there are a lot of changes to the lock file.
One that leads to a difference in Fantomas.Client, which I want to avoid.

paket.lock Outdated
Microsoft.VisualStudio.Threading (>= 16.9.60) - restriction: >= netstandard2.0
Nerdbank.Streams (>= 2.6.81) - restriction: >= netstandard2.0
Newtonsoft.Json (>= 12.0.2) - restriction: >= netstandard2.0
StreamJsonRpc (2.11.35)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We cannot have this change.
The dependencies of Fantomas.Client changed because of this. This might break in Visual Studio.

@thinkbeforecoding
Copy link
Contributor Author

This time it should be better

Copy link
Contributor

@nojaf nojaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, wonderful!
Thank you.

@nojaf nojaf linked an issue Jul 19, 2022 that may be closed by this pull request
@thinkbeforecoding
Copy link
Contributor Author

All builds green!

@nojaf nojaf merged commit 6abfcf6 into fsprojects:master Jul 19, 2022
@nojaf
Copy link
Contributor

nojaf commented Jul 19, 2022

@thinkbeforecoding I've pushed beta 2 to NuGet, it will be available once the indexing is done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FSharp.Core version conflict between Fantomas.Core and Fantomas.FCS
2 participants