Code

Format selection#2272

Code

Merged

nojaf merged 59 commits intofsprojects:masterfsprojects/fantomas:masterfrom nojaf:format-selectionnojaf/fantomas:format-selectionCopy head branch name to clipboardJun 26, 2022

+3,745-2,588

Commits

Commits on Jun 22, 2022

• Remove unused functions in Trivia.fs.

  nojaf

  committed
  8144e02

• Add first proof of concept of FormatSelection.

  nojaf

  committed
  557a80d

• Use mkSynExprNode for toplevel SynExpr nodes.

  nojaf

  committed
  ff3e7fd

• WIP tree shape

  nojaf

  committed
  6f0d969

• Refactor TriviaNodeAssigner to tree structure.

  nojaf

  committed
  0dd892b

• Find node in selection using tree format.

  nojaf

  committed
  f6b341c

• Remove FileIndex check for rangeContainsRange.

  nojaf

  committed
  02548bc

• Consider selection range when collecting trivia.

  nojaf

  committed
  0158041

• Slowly restoring trivia again via tree structure.

  nojaf

  committed
  80f3a6f

• Fix some more unit tests.

  nojaf

  committed
  909a618

• Remove SynComponentInfo_ as actual parent node.

  nojaf

  committed
  fba7e64

• Remove SynValData_ as actual parent node.

  nojaf

  committed
  eade50f

• Use full range for SynField.

  nojaf

  committed
  beb8980

• Run the final continuation for Sequentials.

  nojaf

  committed
  11a4129

• Combined get/set members in a single node.

  nojaf

  committed
  2eb3f17

• Include leading comments in the file range.

  nojaf

  committed
  02113df

• Collect all comments on single line.

  nojaf

  committed
  3b0ec7d

• Use full range for ModuleOrNamespace.

  nojaf

  committed
  ba11165

• Print trivia for SynExpr.Const.

  nojaf

  committed
  0d87680

• Add trivia after last child if nothing fits before.

  nojaf

  committed
  22c6a98

• Restore block comment in PostfixList.

  nojaf

  committed
  b466bf3

• Don't collect blank lines from zero range source code.

  nojaf

  committed
  724812a

• Print trivia after infix app in NewlineInfixApp.

  nojaf

  committed
  0a37edb

• Stay within the boundaries of the source text.

  nojaf

  committed
  57c1127

• Remove old test.

  nojaf

  committed
  131560b

• Correct full range of SynExprRecordField.

  nojaf

  committed
  8edbdc8

• Use SynExpr_Const for synExprToFsAstType.

  nojaf

  committed
  4f7a714

• Include conditional directives in ParsedInput range.

  nojaf

  committed
  69c0919

• Remove SynTypeDefnRepr_ObjectModel as node.

  nojaf

  committed
  3caf284

• Use correct SynModuleOrNamespaceSig_ kinds.

  nojaf

  committed
  bb06a77

• Print trivia for AnonRecordFieldName.

  nojaf

  committed
  956cbc2

• Print trivia before anon record field at right column.

  nojaf

  committed
  7be344d

• Use parsedData from SynExpr.Lambda in AstTransformer.fs.

  nojaf

  committed
  b42c1d4

• Print after trivia for same infix application.

  nojaf

  committed
  61add33

• Combine NewlineInfixApps and SameInfixApps under a single parent node.

  nojaf

  committed
  5083b30

• Add newline when attribute contains comment.

  nojaf

  committed
  22ec136

• Print trivia for SynPat.Or.

  nojaf

  committed
  1716af1

• Add children of valSig node to SynMemberSig.Member.

  nojaf

  committed
  55ceb5d

• Remove duplicate SynType_Paren.

  nojaf

  committed
  cba7064

• Duplicate with/and keyword in SynMemberDefn.Member.

  nojaf

  committed
  59bd3bd

• Take the smallest possible trivia node for comment after source code.

  nojaf

  committed
  d3ca601

• Print leading newlines when formatting a selection.

  nojaf

  committed
  2f38144

• Revisit trivia type names.

  nojaf

  committed
  74157b4

• Clean up Trivia.fs.

  nojaf

  committed
  6ba9350

• Remove SynTypeDefnSigRepr_ObjectModel type.

  nojaf

  committed
  d7c2b91

• Use last node inside SynExpr.App to assign trivia after to.

  nojaf

  committed
  3ae8a4f

• Update to SynAccess range commit from fork.

  nojaf

  committed
  cdaf747

• Print trivia for keyword in union and record declarations.

  nojaf

  committed
  821c143

Commits on Jun 24, 2022

• Take the smallest node after.

  nojaf

  committed
  f410606

• Update compiler to "Add arrow to SynType.Fun trivia".

  nojaf

  committed
  a55c246

• Add trivia after arrow in SynType.Fun.

  Show description for a915c6c
  nojaf

  committed
  a915c6c

• Add regression tests from dotnet/fsharp.

  nojaf

  committed
  dda00cf

• Trim the selection to the first code positions. Try and format that exact trimmed selection.

  nojaf

  committed
  8992c25

• Format certain selections in signature files.

  nojaf

  committed
  cffcfc5

Commits on Jun 25, 2022

• Correct typos and introduce signature file for Selection.fs

  nojaf

  committed
  003747f

• Reestablish format selection in Daemon.

  nojaf

  committed
  1ba7758

• Don't return option for FormatSelection API, try and be consistent with the FormatDocument.

  nojaf

  committed
  5e6fe45

• Add documentation for selection api.

  nojaf

  committed
  81b283a

Commits on Jun 26, 2022

• Clean up.

  nojaf

  committed
  e5d3040