Restore condition with non-generic type parameter #2173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should be working solution, but probably need some DRY treatment. |
|
Fix #2168 |
|
ready for review |
nojaf
approved these changes
Apr 1, 2022
| @@ -599,6 +599,21 @@ let internal colPreEx f2 f1 (c: seq<'T>) f (ctx: Context) = | |||
| else | |||
| colEx f1 c f (f2 ctx) | |||
|
|
|||
| /// Similar to col, but apply two more functions fStart, fEnd at the beginning and the end if the input sequence is bigger thn one item | |||
| let internal colSurr fStart fEnd f1 (c: list<'T>) f (ctx: Context) = | |||
There was a problem hiding this comment.
I was a bit unsure about this abstraction at first.
I'm not entirely convinced col f1 c f should be part of this abstraction.
At the same time, I have no example code where a more general abstraction would make sense, so let's just go with this.
| else | ||
| g) | ||
| ctx | ||
|
|
There was a problem hiding this comment.
I'll remove these additional newlines, triggers me a bit 🙈.
|
I changed the title due to this guidance, https://github.com/fsprojects/fantomas/blob/master/CONTRIBUTING.md#pull-request-title |
3 tasks
jindraivanek
added a commit
to jindraivanek/fantomas
that referenced
this pull request
Apr 9, 2022
* test * add TLongIdent option to TyparSupportsMember * format :) * DRY - new helper function: colSurr * format * Remove blank lines Co-authored-by: nojaf <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.