Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add copy_local: true for Ionide.KeepAChangelog.Tasks and Dotnet.ReproducibleBuilds. #2131

Merged
merged 2 commits into from
Mar 8, 2022

Conversation

nojaf
Copy link
Contributor

@nojaf nojaf commented Mar 7, 2022

image

I noticed Ionide.KeepAChangelog.Tasks and Dotnet.ReproducibleBuilds are listed as dependencies, this should not be the case.
This PR tries to rectify that.

@nojaf nojaf requested a review from baronfel March 7, 2022 20:20
@baronfel
Copy link
Contributor

baronfel commented Mar 7, 2022

you should be able to upload the local package to nuget.info and check the dependencies before merging to make sure they're all gone, but the changes look fine to me

@nojaf
Copy link
Contributor Author

nojaf commented Mar 8, 2022

Thanks, I verified it indeed locally using NuGet package explorer.

@nojaf nojaf merged commit 1e98bc3 into fsprojects:master Mar 8, 2022
@nojaf nojaf deleted the copy_local branch March 8, 2022 07:09
jindraivanek pushed a commit to jindraivanek/fantomas that referenced this pull request Mar 30, 2022
…ducibleBuilds. (fsprojects#2131)

* Add  copy_local: true for Ionide.KeepAChangelog.Tasks and Dotnet.ReproducibleBuilds.

* Add changelog entry.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants