Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 2043: Comment after [] is lost #2074

Merged
merged 2 commits into from
Feb 9, 2022
Merged

Fix 2043: Comment after [] is lost #2074

merged 2 commits into from
Feb 9, 2022

Conversation

dawedawe
Copy link
Member

@dawedawe dawedawe commented Feb 8, 2022

Fixes #2043

  • comments after let bindings with return types
  • comments after SynType_Array in record type

- comments after let bindings with return types
- comments after SynType_Array in record type
Copy link
Contributor

@nojaf nojaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @dawedawe, you are on the right track here.
Thanks again for contributing to this project!

src/Fantomas/CodePrinter.fs Outdated Show resolved Hide resolved
Copy link
Contributor

@nojaf nojaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks!

@nojaf nojaf merged commit 6e88224 into fsprojects:master Feb 9, 2022
jindraivanek pushed a commit to jindraivanek/fantomas that referenced this pull request Mar 30, 2022
* Fix 2043:
- comments after let bindings with return types
- comments after SynType_Array in record type

* - Fix trivia placement by using @nojaf's review suggestion
- Adjust test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Comment after [] is lost, more common in records
2 participants