Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 1954: Don't lose 'mutable' in val signature #1967

Closed
wants to merge 2 commits into from
Closed

Fix 1954: Don't lose 'mutable' in val signature #1967

wants to merge 2 commits into from

Conversation

dawedawe
Copy link
Member

@dawedawe dawedawe commented Nov 9, 2021

Fixes #1954

@dawedawe dawedawe changed the base branch from master to 4.6 November 9, 2021 21:43
nojaf
nojaf requested changes Nov 10, 2021
View reviewed changes
Copy link
Contributor

@nojaf nojaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @dawedawe, thank you for this fix.
Could you please target the master branch for this one?
The reasoning here is that nothing prevents you from fixing this with the current FCS.

I will rebase 4.6 once it is merged on master.
Similar to how #1966 went.

Thanks

@dawedawe dawedawe closed this Nov 10, 2021
@dawedawe dawedawe deleted the fix-1954 branch November 10, 2021 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nojaf nojaf nojaf requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

val mutable in signature loses 'mutable'
2 participants
@dawedawe @nojaf