Run long array sequence test on CI.
#1520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nojaf
commented
Mar 14, 2021
src/Fantomas/AstTransformer.fs
Outdated
| expr2 | ||
| (fun nodes1 -> | ||
| visit expr1 (fun nodes2 -> nodes1 @ nodes2) | ||
| |> finalContinuation) |
There was a problem hiding this comment.
This one was a bit counter-intuitive, I thought I would need to call finalContinuation inside the second lambda.
Had to call it in the first lambda to not blow the stack.
expr2 in the unit test will again be a SynExpr.Sequentials.
Does all of this make some sense?
There was a problem hiding this comment.
I am deeply confused. I would expect to call finalContinuation inside the second lambda, yes. Does the situation improve in Release mode (rather than Debug mode)?
There was a problem hiding this comment.
Release mode works just fine, thanks for the pointer.
Run unit test in release mode.
siwatanejo
reviewed
Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up on the last changes to ASTTransformer.
I had to change
SynExpr.Sequentialbecause it was still blowing the stack.The AST is a heavily nested structure.