add missing raise for formatting functions

[btzo]

fix #1340

Running Fantomas.CoreGlobalTool to format a file without the --check argument, it does the treatment in the else listed below, calling the appropriate function given type of inputPath and outputPath.

fantomas/src/Fantomas.CoreGlobalTool/Program.fs

Lines 386 to 406 in d22dc76

	if check then
	inputPath |> runCheckCommand recurse |> exit
	else
	try
	match inputPath, outputPath with
	| InputPath.Unspecified, _ ->
	eprintfn "Input path is missing..."
	exit 1
	| InputPath.File f, _ when (IgnoreFile.isIgnoredFile f) -> printfn "'%s' was ignored" f
	| InputPath.Folder p1, OutputPath.Notknown -> processFolder p1 p1
	| InputPath.File p1, OutputPath.Notknown -> processFile p1 p1
	| InputPath.File p1, OutputPath.IO p2 -> processFile p1 p2
	| InputPath.Folder p1, OutputPath.IO p2 -> processFolder p1 p2
	| InputPath.StdIn s, OutputPath.IO p -> stringToFile s p FormatConfig.Default
	| InputPath.StdIn s, OutputPath.Notknown
	| InputPath.StdIn s, OutputPath.StdOut -> stringToStdOut s FormatConfig.Default
	| InputPath.File p, OutputPath.StdOut -> fileToStdOut p
	| InputPath.Folder p, OutputPath.StdOut -> allFiles recurse p |> Seq.iter fileToStdOut
	with exn ->
	printfn "%s" exn.Message
	exit 1

The problem is that when an error occurred in one of these functions, it was treated locally but not propagated,
so the try/with condition that changes the error code to 1 is never achieved.

The ideal solution would be to show only the error messages in the last try\with and add tests for each function in the match expression, besides the simple test that I inserted.

What do you think @nojaf ?

[nojaf]

I would remove this with check part, it is implied by the file itself.

[btzo]

Fine

[nojaf]

I would move this to a new file ExitCodeTests as this is not really related to --check.

[btzo]

Yeah, I think it's better this way.

In that case you think I should replicate the other tests from CheckTests to ExitCodeTests, replacing the function checkCode by the function formatCode ?

[nojaf]

Hmm, I won't force you to replicate all tests. I feel like the one you have covered the need here.
The cli application isn't perfect so in this case, I would blink an eye for not having tests that cover all changes.
Maybe just clean up what you have and we can merge this.

[btzo]

Ok

[nojaf]

Hey Mike, that sounds about right.
Thanks for this effort!

[nojaf]

Thanks again @btzo!