Print in keyword after correct SynBinding #1180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auduchinok
reviewed
Oct 2, 2020
| @@ -2000,7 +2000,7 @@ and genExpr astContext synExpr = | |||
| mkRange "IN" binding.RangeOfBindingAndRhs.End e.Range.Start | |||
|
|
|||
| Map.tryFindOrEmptyList IN ctx.TriviaTokenNodes | |||
| |> TriviaHelpers.``keyword token inside range`` inRange | |||
| |> TriviaHelpers.``keyword token after start column and on same line`` inRange | |||
There was a problem hiding this comment.
Probably a better thing to do here would be looking inside the range between the last binding end and the body expression start.
There was a problem hiding this comment.
Yeah, thought of that but we capture nested LetOrUse expressions so that information is lost in CodePrinter.
See
fantomas/src/Fantomas/SourceParser.fs
Line 876 in 3035e5a
auduchinok
reviewed
Oct 2, 2020
| trivia | ||
| |> List.choose (fun t -> | ||
| match t.Type with | ||
| | TriviaNodeType.Token (_, tok) when (range.StartLine = t.Range.StartLine |
There was a problem hiding this comment.
Does it need to handle cases where in is on another line?
do
let _ = ()
in
() // note the different indent is allowed here due to `in` useThere was a problem hiding this comment.
Hmm, I think it should since we are doing this.
Thanks for pointing that out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1176