-
-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SpaceBeforeUppercaseInvocation applied in the middle of a invocation chain #853
Comments
@Bobface not sure I understand; this leads to a compiler error or...? |
@knocte Yes. The original is interpreted as (with extra parenthesis):
The formatted is interpreted as (with extra parenthesis):
|
Note: Knocte and I have agreed to fix this on our side by applying parenthesis like this:
|
Yes, otherwise fixing this would break the purpose of SpaceBeforeUppercaseInvocation setting. |
ElectrumServer.fs had ambiguous parens around the parameters of a function call. The positioning of the parens has been changed according to the style guide. If we didn't apply the parens like in this commit, fantomas would cause a compilation error when trying to format our codebase using our style settings. (See fsprojects/fantomas#853 for more info.)
I feel like we should still fix this at Fantomas side as well. We don't add the space in the first line to indeed not break the code. |
…tIndexedGet. Fixes fsprojects#853. Fixes fsprojects#943
Issue created from fantomas-online
Notice the space between
a.Some.Thing
and("aaa").[0]
. That space makes it a different expression, namely("aaa").[0]
is interpreted as parameter toa.Some.Thing
.Code
Result
Options
Fantomas Next - 4.0.0-alpha-001-1/1/1990
IndentSpaceNum
4
PageWidth
120
SemicolonAtEndOfLine
false
SpaceBeforeParameter
true
SpaceBeforeLowercaseInvocation
true
SpaceBeforeUppercaseInvocation
true
SpaceBeforeClassConstructor
false
SpaceBeforeMember
false
SpaceBeforeColon
false
SpaceAfterComma
true
SpaceBeforeSemicolon
false
SpaceAfterSemicolon
true
IndentOnTryWith
false
SpaceAroundDelimiter
true
MaxIfThenElseShortWidth
40
MaxInfixOperatorExpression
50
MaxRecordWidth
40
MaxArrayOrListWidth
40
MaxLetBindingWidth
40
MultilineBlockBracketsOnSameColumn
false
NewlineBetweenTypeDefinitionAndMembers
false
KeepIfThenInSameLine
false
StrictMode
false
The text was updated successfully, but these errors were encountered: