Crash when formatting with config file

[knocte]

PLEASE USE THE ONLINE TOOL TO REPORT BUGS!!

Sorry, I don't reproduce this problem with the online tool.

Repro code:

namespace GWallet.Backend.Tests

module Foo =

    let someFunc someArg =
        let someRetVal = someArg + 1
        someRetVal


    let someOtherFunc () =
        let var1withAVeryLongLongLongLongLongLongName, var2withAVeryLongLongLongLongLongLongName =
            someFunc 1, someFunc 2

        ()

Fantomas config file:

{
  "PageWidth":80
}

Call fantomas with:

fantomas --config ./fantomas-config.json Repro.fs

Results:

The following exception occurs while formatting stdin: Fantomas.FormatConfig+FormatException: Formatted content is not valid F# code
   at [email protected](Boolean _arg2) in /home/runner/work/fantomas/fantomas/src/Fantomas/FakeHelpers.fs:line 54
   at Microsoft.FSharp.Control.AsyncPrimitives.CallThenInvokeNoHijackCheck[a,b](AsyncActivation`1 ctxt, FSharpFunc`2 userCode, b result1) in F:\workspace\_work\1\s\src\fsharp\FSharp.Core\async.fs:line 417
   at [email protected](AsyncActivation`1 ctxt) in /home/runner/work/fantomas/fantomas/src/Fantomas/CodeFormatterImpl.fs:line 377
   at Microsoft.FSharp.Control.Trampoline.Execute(FSharpFunc`2 firstAction) in F:\workspace\_work\1\s\src\fsharp\FSharp.Core\async.fs:line 109
--- End of stack trace from previous location where exception was thrown ---
   at Microsoft.FSharp.Control.AsyncResult`1.Commit() in F:\workspace\_work\1\s\src\fsharp\FSharp.Core\async.fs:line 350
   at Microsoft.FSharp.Control.AsyncPrimitives.RunSynchronouslyInCurrentThread[a](CancellationToken cancellationToken, FSharpAsync`1 computation) in F:\workspace\_work\1\s\src\fsharp\FSharp.Core\async.fs:line 882
   at Microsoft.FSharp.Control.AsyncPrimitives.RunSynchronously[T](CancellationToken cancellationToken, FSharpAsync`1 computation, FSharpOption`1 timeout) in F:\workspace\_work\1\s\src\fsharp\FSharp.Core\async.fs:line 890
   at Microsoft.FSharp.Control.FSharpAsync.RunSynchronously[T](FSharpAsync`1 computation, FSharpOption`1 timeout, FSharpOption`1 cancellationToken) in F:\workspace\_work\1\s\src\fsharp\FSharp.Core\async.fs:line 1154
   at Program.processSourceString(Boolean isFsiFile, String s, FSharpChoice`2 tw, FormatConfig config) in /home/runner/work/fantomas/fantomas/src/Fantomas.CoreGlobalTool/Program.fs:line 87
   at Program.stringToFile@273(Boolean force, Boolean profile, String s, String outFile, FormatConfig config) in /home/runner/work/fantomas/fantomas/src/Fantomas.CoreGlobalTool/Program.fs:line 281

[Bobface]

@nojaf The reason for the error is a formatting error. This is the result of the formatting of the supplied source:

namespace GWallet.Backend.Tests

module Foo =

    let someFunc someArg =
        let someRetVal = someArg + 1
        someRetVal


    let someOtherFunc () =
        let var1withAVeryLongLongLongLongLongLongName,
            var2withAVeryLongLongLongLongLongLongName
            =
            someFunc 1, someFunc 2

        ()

The two long variables being split into two lines seems to be invalid F# - I tried to compile it and got an error. Moving both variable names into the same line makes it compile.

I would begin working on this issue by making sure that multiple variable names are always kept on the same line, including the = sign. Let me know what you think about that.

[nojaf]

@Bobface what happens if you add ( ) instead?

    let someOtherFunc () =
        let (var1withAVeryLongLongLongLongLongLongName,
             var2withAVeryLongLongLongLongLongLongName)
            =
            someFunc 1, someFunc 2

        ()

[Bobface]

@nojaf That compiles fine. Is this your preferred way?

[knocte]

Mmm, but if fantomas does this, it would be the first case I know that it adds parenthesis when they were not there already, which to me doesn't sound as the best approach.

[nojaf]

Fantomas does this in other places as well.
Example: lazy keyword.

This is a trade-off situation. Putting it all on the same line will lead to someone opening an issue "hey the page width is not respected" or "in-consist style when tuple destructering is involved".
Having the extra parenthesis while they were not there in the first place, leads to your remark @knocte.

I would go for the parenthesis approach here.

[knocte]

I would go for the parenthesis approach here

This would make it even harder to come up with a solution for #684 :(

[nojaf]

Not necessarily, the case where we add parenthesis is clearly defined and scoped to the area to tuple destructuring in let bindings. So I don't see an immediate correlation to #684 here.