Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken links in Readme.md #791

Closed
milbrandt opened this issue Apr 24, 2020 · 4 comments · Fixed by #792
Closed

Broken links in Readme.md #791

milbrandt opened this issue Apr 24, 2020 · 4 comments · Fixed by #792

Comments

@milbrandt
Copy link

Seems like Readme or at least the section Upgrading FSharp.Compiler.Service is not maintained for some time.

Didn't check the remaining links.

@nojaf
Copy link
Contributor

nojaf commented Apr 25, 2020

Hello,

F# tokens was literally deprecated yesterday
image

The main gist is that the tools listed in the Upgrading FSharp.Compiler.Service are now combined into one tool: https://github.com/fsprojects/fantomas-tools

I'll update the readme.

nojaf added a commit to nojaf/fantomas that referenced this issue Apr 25, 2020
@milbrandt
Copy link
Author

Thanks @nojaf
On F# tokens repo I saw only the top banner of Githup and didn't checked when it was deprecated. Obviously I had bad luck with the moment in time. I came from your issue at FSharpLint and didn't digest that deep.

@nojaf
Copy link
Contributor

nojaf commented Apr 25, 2020

No worries @milbrandt, anything I can do to help you with the investigation of the FSharpLint?

@milbrandt
Copy link
Author

Sorry no, I'm not further investigating - but I know the issue there for multitargetting projects. But someone now added that he has the issue also for a single-project case.
As I suspect it's an issue in dotnet-proj-infoor the usage thereof I opened there an issue.
Actually, I'm only using FSharpLint in another project.

nojaf added a commit that referenced this issue Apr 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants