Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option parameter name is lost in tuple #2144

Closed
1 of 3 tasks
nojaf opened this issue Mar 11, 2022 · 0 comments · Fixed by #2146
Closed
1 of 3 tasks

Option parameter name is lost in tuple #2144

nojaf opened this issue Mar 11, 2022 · 0 comments · Fixed by #2146

Comments

@nojaf
Copy link
Contributor

nojaf commented Mar 11, 2022

Issue created from fantomas-online

Code

// Copyright (c) Microsoft Corporation.  All Rights Reserved.  See License.txt in the project root for license information.

namespace Microsoft.FSharp.Control
    
    [<Sealed>]
    [<CompiledName("FSharpAsync")>]
    type Async =
        static member AwaitEvent: event:IEvent<'Del,'T> * ?cancelAction : (unit -> unit) -> Async<'T> when 'Del : delegate<'T,unit> and 'Del :> System.Delegate 

Result

// Copyright (c) Microsoft Corporation.  All Rights Reserved.  See License.txt in the project root for license information.

namespace Microsoft.FSharp.Control

[<Sealed>]
[<CompiledName("FSharpAsync")>]
type Async =
    static member AwaitEvent: event: IEvent<'Del, 'T> * (unit -> unit) -> Async<'T>
        when 'Del: delegate<'T, unit> and 'Del :> System.Delegate

Problem description

cancelAction was lost after formatting.
This leads to a compiler bug in the original source at: https://github.com/dotnet/fsharp/blob/dab9d43fe3530f1df8de11fec4d5d278e8f3893e/src/fsharp/FSharp.Core/async.fsi#L360-L380

Extra information

  • The formatted result breaks by code.
  • The formatted result gives compiler warnings.
  • I or my company would be willing to help fix this.

Options

Fantomas master branch at 2022-03-11T12:09:54Z - b2d96b2

Default Fantomas configuration

Signature file

Did you know that you can ignore files when formatting from fantomas-tool or the FAKE targets by using a .fantomasignore file?

@nojaf nojaf changed the title Option parameter name is lost Option parameter name is lost in tuple Mar 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant