Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiline if condition in KeepIndentInBranch leads to warnings #1729

Closed
1 of 3 tasks
nojaf opened this issue May 18, 2021 · 0 comments · Fixed by #1730
Closed
1 of 3 tasks

Multiline if condition in KeepIndentInBranch leads to warnings #1729

nojaf opened this issue May 18, 2021 · 0 comments · Fixed by #1730

Comments

@nojaf
Copy link
Contributor

nojaf commented May 18, 2021

Issue created from fantomas-online

Code

let x y =
            if not (
                result.HasResultsFor(
                    [ "label"
                      "ipv4"
                      "macAddress"
                      "medium"
                      "manufacturer" ]
                )
            ) then
                None
            else

            let label = string result.["label"]
            let ipv4 = string result.["ipv4"]
            None

Result

let x y =
    if not (
        result.HasResultsFor(
            [ "label"
              "ipv4"
              "macAddress"
              "medium"
              "manufacturer" ]
        )
    ) then
        None
    else

    let label = string result.["label"]
    let ipv4 = string result.["ipv4"]
    None

Problem description

Offset warnings occur, in this case I'd go for the indent and newline fix as suggested by the style guide.

let x y =
    if 
        not (
            result.HasResultsFor(
                [ "label"
                   "ipv4"
                   "macAddress"
                   "medium"
                   "manufacturer" ]
            )
        ) 
    then
        None
    else

    let label = string result.["label"]
    let ipv4 = string result.["ipv4"]
    None

Extra information

  • The formatted result breaks by code.
  • The formatted result gives compiler warnings.
  • I or my company would be willing to help fix this.

Options

Fantomas Master at 05/16/2021 17:45:16 - 76ffe36

    { config with
                KeepIndentInBranch = true }

Did you know that you can ignore files when formatting from fantomas-tool or the FAKE targets by using a .fantomasignore file?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant