Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Idempotency problem with comments at the end of code #1604

Closed
3 tasks
Smaug123 opened this issue Apr 6, 2021 · 0 comments · Fixed by #1612
Closed
3 tasks

Idempotency problem with comments at the end of code #1604

Smaug123 opened this issue Apr 6, 2021 · 0 comments · Fixed by #1612

Comments

@Smaug123
Copy link
Contributor

Smaug123 commented Apr 6, 2021

Issue created from fantomas-online

Formatted code

let foo = bar // bar
//// hi!

Reformatted code

let foo = bar

Problem description

Fantomas was not able to produce the same code after reformatting the result.

We've lost the trailing comment, too.

Note that the initial format was fine - it was only when Fantomas added a newline on the end that we started losing the comment.

Extra information

  • The formatted result breaks by code.
  • The formatted result gives compiler warnings.
  • I or my company would be willing to help fix this.

Options

Fantomas Master at 04/05/2021 16:09:34 - 31922c0

Default Fantomas configuration

Did you know that you can ignore files when formatting from fantomas-tool or the FAKE targets by using a .fantomasignore file?

nojaf added a commit to nojaf/fantomas that referenced this issue Apr 6, 2021
nojaf added a commit that referenced this issue Apr 6, 2021
…as one trivia. (#1612)

* Don't combine LineCommentAfterSourceCode and LineCommentOnSingleLine as one trivia. Fixes #1604.

* Don't pass nextTokens.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants