Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nested matches format into something invalid #1400

Closed
1 of 3 tasks
Smaug123 opened this issue Jan 27, 2021 · 1 comment · Fixed by #1459
Closed
1 of 3 tasks

Nested matches format into something invalid #1400

Smaug123 opened this issue Jan 27, 2021 · 1 comment · Fixed by #1459

Comments

@Smaug123
Copy link
Contributor

Issue created from fantomas-online

Code

let u = ""
match
    match u with
    | null -> ""
    | s -> s
    with
    | "" -> x
    | _ -> failwith ""

Result

let u = ""

match match u with
      | null -> ""
      | s -> s with
| "" -> x
| _ -> failwith ""

Problem description

This is absolutely hilarious, and I am going to change our code here because the pattern is absurd. But it is a bug in Fantomas, so I'll raise it; Fantomas shouldn't produce invalid F# even if the input F# was this mad.

Extra information

  • The formatted result breaks by code.
  • The formatted result gives compiler warnings.
  • I or my company would be willing to help fix this.

Options

Fantomas Master at 01/27/2021 07:36:19 - 138146e

Default Fantomas configuration

Did you know that you can ignore files when formatting from fantomas-tool or the FAKE targets by using a .fantomasignore file?

@nojaf
Copy link
Contributor

nojaf commented Feb 5, 2021

Hey Patrick, it was right of you to raise this.
I do feel like the fix for this might be a good old wrap it with parenthesis 😅.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants