Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

comment after paren is repeated #1084

Closed
3 tasks
nojaf opened this issue Sep 4, 2020 · 0 comments · Fixed by #1087
Closed
3 tasks

comment after paren is repeated #1084

nojaf opened this issue Sep 4, 2020 · 0 comments · Fixed by #1087

Comments

@nojaf
Copy link
Contributor

nojaf commented Sep 4, 2020

Issue created from fantomas-online

Code

let private tokenizeLines (sourceTokenizer: FSharpSourceTokenizer) allLines state =
  allLines
  |> List.mapi (fun index line -> line, (index + 1)) // line number is needed in tokenizeLine
  |> List.fold (fun (state, tokens) (line, lineNumber) ->
      let tokenizer = sourceTokenizer.CreateLineTokenizer(line)
      let nextState, tokensOfLine =
          tokenizeLine tokenizer allLines state lineNumber []
      
      let allTokens = List.append tokens (List.rev tokensOfLine) // tokens of line are add in reversed order
      (nextState, allTokens)
  ) (state, []) // empty tokens to start with
  |> snd // ignore the state

Result

let private tokenizeLines (sourceTokenizer: FSharpSourceTokenizer) allLines state =
    allLines
    |> List.mapi (fun index line -> line, (index + 1)) // line number is needed in tokenizeLine
    |> List.fold (fun (state, tokens) (line, lineNumber) ->
        let tokenizer =
            sourceTokenizer.CreateLineTokenizer(line)

        let nextState, tokensOfLine =
            tokenizeLine tokenizer allLines state lineNumber []

        let allTokens =
            List.append tokens (List.rev tokensOfLine) // tokens of line are add in reversed order

        (nextState, allTokens))  // tokens of line are add in reversed order
           (state, []) // empty tokens to start with
    |> snd // ignore the state

Problem description

Similar to #1082, the scope of RParen token should be smaller.

Extra information

  • The formatted result breaks by code.
  • The formatted result gives compiler warnings.
  • I or my company would be willing to help fix this.

Options

Fantomas Master at 9/4/2020

Default Fantomas configuration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant