Extract setting for preference of newline placement for computation e…

…xpressions (#2746) * Add new setting * Add test * Implement new setting * Add setting-specific tests to its own file * Fix an issue with applying to lambdas * Fix issue when applying to LetBang and AndBang * Fix all failing tests, some cleanup * Remove invalid tests, some more cleanup * Rename some helpers * temp * Cleanup, add test * Rename setting * Use local Fantomas.Core reference for Configuration.fsx. * Rename some things and fix assertion * Update docs * Simplify isStroustrupStyleExpr * Rename test file to match setting name. * Add additional test to highlight that settings don't affect each other. --------- Co-authored-by: nojaf <[email protected]>
fsprojects · Feb 2, 2023 · 5828265 · 5828265
1 parent e851d3f
commit 5828265
Show file tree

Hide file tree

Showing 23 changed files with 786 additions and 742 deletions.
diff --git a/docs/docs/end-users/Configuration.fsx b/docs/docs/end-users/Configuration.fsx
@@ -641,6 +641,26 @@ formatCode
         MultilineBracketStyle = Stroustrup }
 (*** include-output ***)
 
+(**
+<fantomas-setting name="fsharp_newline_before_multiline_computation_expression" green></fantomas-setting>
+
+Insert a newline before a computation expression that spans multiple lines
+
+Default = true
+*)
+
+formatCode
+    """ 
+    let something =
+        task {
+            let! thing = otherThing ()
+            return 5
+        }
+    """
+    { FormatConfig.Default with
+        NewlineBeforeMultilineComputationExpression = false }
+(*** include-output ***)
+
 (**
 ## G-Research style
 

diff --git a/src/Fantomas.Core.Tests/Fantomas.Core.Tests.fsproj b/src/Fantomas.Core.Tests/Fantomas.Core.Tests.fsproj
@@ -35,6 +35,7 @@
     <Compile Include="ListTests.fs" />
     <Compile Include="CompilerDirectivesTests.fs" />
     <Compile Include="ComputationExpressionTests.fs" />
+    <Compile Include="NewlineBeforeMultilineComputationExpressionTests.fs" />
     <Compile Include="TypeProviderTests.fs" />
     <Compile Include="FormattingSelectionOnlyTests.fs" />
     <Compile Include="ValidationTests.fs" />