Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/nuget symbols #24

Merged
merged 2 commits into from
Oct 25, 2018
Merged

Feature/nuget symbols #24

merged 2 commits into from
Oct 25, 2018

Conversation

mchaloupka
Copy link
Collaborator

Modifying the nuget creation to include sources and generating a symbols package. Moreover, turning on the generation of xml codedoc.

bartelink
bartelink approved these changes Oct 22, 2018
View reviewed changes
Copy link
Member

@bartelink bartelink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is all good - consider making the doc gen conditional and using sourcelink a la:
jet/FsCodec@aa9bae0

TickSpec/TickSpec.fsproj Outdated Show resolved Hide resolved
@mchaloupka
Copy link
Collaborator Author

Hmm, after trying, I would say that this pull request is actually another reason to remove paket.

It is not possible to include symbols when paket is used, because of: fsprojects/Paket#3272
It is not possible to have development dependency, as dotnet pack does not have that information from paket and paket does not work with multiple targets:
fsprojects/Paket#3191
fsprojects/Paket#2370

So, in my opinion the correct approach is to merge the paket removal and then merge this. Do you agree @michalkovy and @bartelink ?

@bartelink
Copy link
Member

Go for it!

@michalkovy
Copy link
Contributor

I am fine with Paket removal, we can potentially put it back once all the issues are fixed

@mchaloupka mchaloupka force-pushed the feature/nuget-symbols branch from bc57c74 to e459f54 Compare October 25, 2018 11:10
@mchaloupka mchaloupka force-pushed the feature/nuget-symbols branch from e459f54 to 263c86c Compare October 25, 2018 11:14
@mchaloupka mchaloupka merged commit 27bd5e5 into master Oct 25, 2018
@mchaloupka mchaloupka deleted the feature/nuget-symbols branch October 25, 2018 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartelink bartelink bartelink approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mchaloupka @bartelink @michalkovy