Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly setting the correct nuget.exe #111

Closed
wants to merge 1 commit into from

Conversation

Vidarls
Copy link
Contributor

@Vidarls Vidarls commented Oct 22, 2014

Apparently some packages (cough MySql.Data, 5.1.7.0 cough) for some reason have a nuget.exe in them, and it is not exactly the latest version.

By default, the Fake nuget helper searches subdirectories(?) to find the first nuget.exe there is and uses that. Problems occurs when it is a really old version that crashes for unknown reasons due to complicated new fields like release notes.

(Yes I have spent way too much time finding the cause of why my nuget package would not build today.)

Anyway, this change explicitly sets the toolpath used in build.fsx to the nuget.exe from the nuget.commandline package. (So hopefully no-one else have to spend time troubleshooting this).

Avoiding picking the wrong nuget.exe if multiple exsits in
subdirectories.
@forki
Copy link
Member

forki commented Oct 22, 2014

Yes this works for your use case, but will break existing installations. I think we should fix this directly in FAKE and specify a priority.

@Vidarls
Copy link
Contributor Author

Vidarls commented Oct 22, 2014

Just to play the devils advocate here: Are there any existing installations of a scaffolding framework to break?

(Other than that, yes fixing it in FAKE would be better, and avoid other people having their project broken due to adding a package with a nuget.exe in them)

@forki
Copy link
Member

forki commented Oct 22, 2014

Yes. I merge this all the time downstream to existing solutions in our
company. Unfortunately we have different path.
On Oct 22, 2014 11:50 AM, "Vidar Løvbrekke Sømme" [email protected]
wrote:

Just to play the devils advocate here: Are there any existing
installations of a scaffolding framework to break?

(Other than that, yes fixing it in FAKE would be better, and avoid other
people having their project broken due to adding a package with a nuget.exe
in them)


Reply to this email directly or view it on GitHub
#111 (comment)
.

@Vidarls
Copy link
Contributor Author

Vidarls commented Oct 22, 2014

Ok

@Vidarls Vidarls closed this Oct 22, 2014
@forki
Copy link
Member

forki commented Oct 22, 2014

I will fix it in FAKE. Today
On Oct 22, 2014 11:56 AM, "Vidar Løvbrekke Sømme" [email protected]
wrote:

Closed #111 #111.


Reply to this email directly or view it on GitHub
#111 (comment).

@Vidarls
Copy link
Contributor Author

Vidarls commented Oct 22, 2014

Didn't see your comment before I created the issue in fake.

Much appreciated

@Vidarls Vidarls deleted the explicit_nuget_path branch October 22, 2014 10:43
@Vidarls
Copy link
Contributor Author

Vidarls commented Oct 23, 2014

@forki Just out of curiosity, how do you propagate say the improvements on build.fsx or generate.fsx to the downstream solution as those are just .template files in the Scaffolding project.

@forki
Copy link
Member

forki commented Oct 23, 2014

pretty easy:

add a second git remote:

git remote add scaffold https://github.com/fsprojects/ProjectScaffold.git

from time to time I do:

git pull scaffold master

it merges very well (since git is not based on file names).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants